Goodreads Developers discussion
bugs
>
book.show API call redirecting to mobile web on mobile device
date
newest »
newest »
The URL I use is slightly different:http://www.goodreads.com/book/show/[[....xml?key=[[APP_KEY]]&page=[[PAGE_NUM]]
Following up: this is still an issue, but only when the request is signed. The book.show request does not require being signed, so if I don't sign it I get results back. I was signing this request in the hope that, if it were signed, the returned reviews would include reviews that are private to the signed user.
I see, my understanding of how privacy works may be a littled skewed then.Let's say we have three users: Aaron, Beatrice, and Clyde.
Aaron is friends with Beatrice and Clyde. Aaron has set his profile to public.
Beatrice is friends with Aaron, but not Clyde. Beatrice has set her profile to private.
Clyde is friends with Aaron, but not Beatrice. Clyde has a public profile.
When Aaron signs in, he can see the books that both Beatrice and Clyde have put on their shelves, as well as reviews for those books.
When Beatrice signs in, she can see the books that both Aaron and Clyde have put on their shelves, as well as reviews for those books.
When Clyde signs in, he can see the books that Aaron has put on his shelves, as well as the reviews for those books. He is not able to view the books on Beatrice's shelves (they are not friends) nor is he able to see the reviews she has written for those books.
That was my assumption. Based on your comment, I take it that all reviews, regardless of your profile settings, are public. So in that case, while Clyde could not request the list of books on Beatrice's shelves, if he were to view book reviews for a book that Beatrice has reviewed, he might see her review.
Oh, I forgot one thing, we have a checkbox in settings for "allow partners of Goodreads to display my reviews". This should apply to the non-oauth request, but not an oauth request."Based on your comment, I take it that all reviews, regardless of your profile settings, are public." other than that setting, this is correct.
We have private profiles, but not private reviews. Sorry this is confusing.
No problem, and thanks for the clarification! So when I make a request using my application key, but not signing the request, the user must have the 'allow partners of Goodreads to display my reviews' option checked for the reviews to appear. If I do sign the request, then all reviews will appear.Based on that, I do think there is a bug on the book.show request when signed from a mobile device. When I leave my book.show request unsigned, I get back xml. When I sign the book.show request I receive the HTML for the mobile version of that book's web page.
One question, do you have ".xml" or "format=xml" in your query string?If not, that may fix it.
Good call! I did not have either of those on my request. I added them in and the signed request began to work."format=xml" -- is this an undocumented option on all requests? If so, it would be fairly simple for me to add it to all of my calls.
So our routing is "supposed" to always recongnise like "book/show/5.xml" which should set the format parameter (internally) to "xml". But doing book/show/5?format=xml will always work due to the way routing works.
method from a mobile device are getting redirected to the mobile page for the book rather than returning the expected xml. Requests to the same URL from a desktop machine receive XML as expected.