Goodreads Librarians Group discussion

Magick Without Tears
This topic is about Magick Without Tears
42 views
Issues with Quotes > Odd new error in quote engine

Comments Showing 1-4 of 4 (4 new)    post a comment »
dateUp arrow    newest »

Keith (kgf0) | 377 comments This might be more appropriate of the Bugs forum, but the behavior might be somewhat intentional, so I wanted to check here first.

I attempted to add the following as a quote, in a manner which I have used many times before, most recently 09 March 10:48AM PDT:

"You must on no account attempt to use the squares given in the Book of the Sacred Magic of Abramelin the Mage until you have succeeded in the Operation. More, unless you mean to perform it, and are prepared to go to any length to do so, you are a fool to have the book in your possession at all. Those squares are liable to get loose and do things on their own initiative; and you won't like it."

The link inside the quote is a standard, internal Goodreads book link including the vertical-bar and numerical edition qualifier, intended to clearly indicate to which book the author of the quote is referring. That link style worked four days ago. Attempting to save today produces the following error message:

1 error prohibited this record from being saved:

Body may not contain Web addresses (URLs)


The rule, as expressed in the error message, is quite sane given the problems we have with linkspam; however, it appears to me as if the logic checking for such links has gotten overzealous, or else it's checking against the parsed quote text, rather than the input text. The body, as entered, does not actually contain a URL, and anything linkable internally should be safe, I would think, unless I missed some big news.

Did we really intend to block internal links in quotes? If so, can I ask why? That seems like one of *the* most useful places to have internal links, especially for author links when quotes are entered *about* other writers (most especially when the quote just refers to a last name, leaving the precise author ambiguous unless linked to a profile). FWIW, while the above is a book link, I tested for author links as well before posting, and those produce the same error message.


message 2: by rivka, Former Moderator (new)

rivka | 45177 comments Mod
Keith wrote: "Did we really intend to block internal links in quotes?"

That's an interesting issue. I will mention it to our engineers.


message 3: by William (new)

William Cline | 5 comments Sorry, this was another instance of our URL filter being over-zealous. I've fixed it so that it shouldn't block internal links any longer.

Thanks for bringing it up, Keith. Sorry for the bother.


message 4: by Keith (last edited Mar 14, 2014 07:11PM) (new) - rated it 5 stars

Keith (kgf0) | 377 comments I'm do SQA for a living; this is less bother than it is second nature. Thanks for the fix. I'll try adding that quote again in a few hours to confirm it.

ETA: fix comfirmed; quote added; thanks extended.


back to top